Add kubectl to e2e image. #2182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
guess you also want to bump the image |
|
@krzyzacy I do, but I have a few PRs out for modifying the same image concurrently, so I was going to wait until a few (or all of them) got merged and then send a follow-up PR to bump the image and reference all of the PRs it would include. Otherwise, I have to guess at the order they'll get merged in so each can bump the image id appropriately. |
fejta
reviewed
Mar 9, 2017
| @@ -42,6 +42,9 @@ RUN mkdir -p /tmp/terraform/ && \ | |||
| ) && \ | |||
| rm -rf /tmp/terraform | |||
|
|
|||
| # Needed by kubetest | |||
| RUN gcloud components update kubectl | |||
There was a problem hiding this comment.
Would this be better here: https://github.com/kubernetes/test-infra/blob/master/jenkins/e2e-image/Dockerfile#L50 ?
There was a problem hiding this comment.
Sure. Let me update to move it there.
|
/assign |
This is a dependency of kubetest.
|
I've now moved the command into the base e2e image. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
This was referenced Mar 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a dependency of
kubetest, and I believe it got removed from the base image somewhere along the way.