Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

start running make test on all Kubernetes PRs, drop caching to match bazel test … #21008

Merged
merged 1 commit into from
Feb 25, 2021
Merged

start running make test on all Kubernetes PRs, drop caching to match bazel test … #21008

merged 1 commit into from
Feb 25, 2021

Conversation

BenTheElder
Copy link
Member

…-race

/cc @spiffxp @dims @liggitt

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 24, 2021
BenTheElder
BenTheElder commented Feb 24, 2021
View reviewed changes
config/jobs/kubernetes/sig-testing/make-test.yaml
@@ -10,22 +10,15 @@ presubmits:
labels:
preset-service-account: "true"
optional: true
always_run: false
always_run: true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been testing this, it behaves as well as the bazel job.
We can start running it everywhere but not require it, then transition which job is required, then phase out the old job.

BenTheElder
BenTheElder commented Feb 24, 2021
View reviewed changes
config/jobs/kubernetes/sig-testing/make-test.yaml
args:
- -c
- |
# Restore the cache
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not helping us currently, prefer to match bazel for now (-race)

BenTheElder
BenTheElder commented Feb 24, 2021
View reviewed changes
config/jobs/kubernetes/sig-testing/make-test.yaml
# Run tests as usual
time make test KUBE_TIMEOUT=--timeout=240s
# TODO: stop depending on custom timeout
- make test KUBE_RACE=-race KUBE_TIMEOUT=--timeout=240s
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should reduce this down to make test KUBE_RACE=-race but that should come later, priority is smooth transition

@BenTheElder
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot added the area/gubernator Issues or PRs related to code in /gubernator label Feb 24, 2021
spiffxp
spiffxp reviewed Feb 24, 2021
View reviewed changes
gubernator/config.yaml Outdated
@@ -34,6 +34,7 @@ jobs:
- pull-kubernetes-e2e-kind
- pull-kubernetes-e2e-kind-ipv6
- pull-kubernetes-integration
- pull-kubernetes-make-test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Silly nit I didn't catch before the PR introducing this job merged: WDYT about pull-kubernetes-test or pull-kubernetes-unit instead? Avoid baking the name of how they're invoked into the job

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for pull-kubernetes-unit

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

spiffxp
spiffxp approved these changes Feb 25, 2021
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 25, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 71b2f7d into kubernetes:master Feb 25, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 25, 2021
@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key make-test.yaml using file config/jobs/kubernetes/sig-testing/make-test.yaml

In response to this:

…-race

/cc @spiffxp @dims @liggitt

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BenTheElder BenTheElder deleted the make-test-plz branch February 25, 2021 01:28
@BenTheElder BenTheElder mentioned this pull request Feb 25, 2021
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp approved these changes

@dims dims Awaiting requested review from dims

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@spiffxp spiffxp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/gubernator Issues or PRs related to code in /gubernator area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
4 participants
@BenTheElder @k8s-ci-robot @spiffxp @liggitt