From 4aa4759ee8ad1d3628186f723877b955d2904172 Mon Sep 17 00:00:00 2001 From: hasheddan Date: Tue, 10 Nov 2020 12:00:49 -0600 Subject: [PATCH] Revert "Add test for testrgrid alert emails on release-blocking jobs" An existing test checks for this attribute more holistically. This reverts commit a21a0265d0c925b07e3b77414aa90a87599ebb09. --- config/tests/jobs/jobs_test.go | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/config/tests/jobs/jobs_test.go b/config/tests/jobs/jobs_test.go index b9864f0b0104..ab67b52a3696 100644 --- a/config/tests/jobs/jobs_test.go +++ b/config/tests/jobs/jobs_test.go @@ -969,13 +969,6 @@ func verifyPodQOSGuaranteed(spec *coreapi.PodSpec) (errs []error) { return errs } -func hasAlertEmails(job cfg.JobBase) bool { - if _, ok := job.Annotations["testgrid-alert-email"]; !ok { - return false - } - return true -} - // A job is merge-blocking if it: // - is not optional // - reports (aka does not skip reporting) @@ -1025,19 +1018,6 @@ func TestKubernetesReleaseBlockingJobsMustHavePodQOSGuaranteed(t *testing.T) { } } -// TODO: s/Should/Must and s/Logf/Errorf when all jobs pass -func TestKubernetesReleaseBlockingJobsMustHaveContactInformation(t *testing.T) { - for _, job := range allStaticJobs() { - // Only consider Pods that are release-blocking - if job.Spec == nil || !isKubernetesReleaseBlocking(job) { - continue - } - if !hasAlertEmails(job) { - t.Logf("%v: should have testgrid-alert-email(s)", job.Name) - } - } -} - // TODO: may need to rewrite to handle nodepools or handle jobs that can't be // migrated over for a while // TODO: s/Should/Must and s/Logf/Errorf when all jobs pass