Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration presubmit to aws-ebs-csi-driver #13860

Merged
merged 1 commit into from
Aug 13, 2019

Conversation

wongma7
Copy link
Contributor

@wongma7 wongma7 commented Aug 12, 2019

I've set always_run to false which means the test will only run when requested. I plan to make a PR adding the make test-e2e-migration rule and make sure the tests runs as expected, then move this to a periodic job.
/cc @leakingtapan

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 12, 2019
@wongma7
Copy link
Contributor Author

wongma7 commented Aug 12, 2019

/assign @leakingtapan

@leakingtapan
Copy link

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 13, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5a7a319f0715ebc80fc21aaada4b807da78a5d3a

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leakingtapan, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2019
@k8s-ci-robot k8s-ci-robot merged commit 0a2e51d into kubernetes:master Aug 13, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 13, 2019
@k8s-ci-robot
Copy link
Contributor

@wongma7: Updated the job-config configmap in namespace default using the following files:

  • key aws-ebs-csi-driver-presubmits.yaml using file config/jobs/kubernetes-sigs/aws-ebs-csi-driver/aws-ebs-csi-driver-presubmits.yaml

In response to this:

I've set always_run to false which means the test will only run when requested. I plan to make a PR adding the make test-e2e-migration rule and make sure the tests runs as expected, then move this to a periodic job.
/cc @leakingtapan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants