Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shall we add permission limit for subproject #15527

Closed
Colstuwjx opened this issue Dec 8, 2019 · 2 comments
Closed

Shall we add permission limit for subproject #15527

Colstuwjx opened this issue Dec 8, 2019 · 2 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@Colstuwjx
Copy link
Contributor

Hi team,

We have some subprojects from our community, and sometimes the PR approver and reviewer for the subprojects is distinct with the main project, for example, our website docs owner is inside OWNERS.md of the website root, and content/en has its own OWNERS.md, what's more, blog under the content/en is another subproject, and it has its own OWNERS.

The problem is, when someone submitted a PR for blog related issues, docs OWNER and content/en OWNER could also do approve. This action is NOT suitable to the context, since the blog content is subproject from the website, and should be reviewed\approved from the blog subproject OWNERS.

What would you like to be added:
For OWNERS.md, we could add some permission level limitations and overrides, such as the subproject things should ONLY be approved/reviewed by the subproject OWNERS.

Why is this needed:
Currently, we seems not limit to this, and the project OWNERS could do approve/review for subproject PRs without subproject OWNERS reviews. It would make our subproject messy, so we should enhance this level permission controls.

Thanks.

@Colstuwjx Colstuwjx added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 8, 2019
@alvaroaleman
Copy link
Member

I believe this can be achieved already by setting no_parent_owners: true in the subprojects OWNERS file, ref: https://github.com/kubernetes/community/blob/master/contributors/guide/owners.md

@Colstuwjx
Copy link
Contributor Author

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants