From 83e564924c1f146ff5cc02b6a24dee5921e9d139 Mon Sep 17 00:00:00 2001 From: Antonio Ojea Date: Thu, 12 Dec 2024 20:10:12 +0000 Subject: [PATCH] add optional presubmit job to run apidiff on the client-go module --- .../jobs/kubernetes/sig-testing/apidiff.yaml | 35 +++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/config/jobs/kubernetes/sig-testing/apidiff.yaml b/config/jobs/kubernetes/sig-testing/apidiff.yaml index 5f2f3512927f..bccefafca7ff 100644 --- a/config/jobs/kubernetes/sig-testing/apidiff.yaml +++ b/config/jobs/kubernetes/sig-testing/apidiff.yaml @@ -56,5 +56,40 @@ presubmits: cpu: 2 memory: 12Gi + - name: pull-kubernetes-apidiff-client-go + cluster: eks-prow-build-cluster + # A job which automatically runs for changes in client-go or the generated code + # to have visibility on the changes that will impact the external projects + # that are using the Kubernetes golang clients + run_if_changed: '(^staging\/src\/k8s.io\/client-go)|(^staging\/src\/k8s.io\/code-generator\/examples)' + optional: true + decorate: true + annotations: + # The apidiff.sh script uses the latest revision of apidiff. + # There is no guarantee that this will continue to work for + # older branches, so let's not even create per-release + # copies of this job. + fork-per-release: "false" + testgrid-dashboards: sig-testing-misc + testgrid-create-test-group: 'true' + path_alias: k8s.io/kubernetes + spec: + containers: + - image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20241128-8df65c072f-master + command: + - runner.sh + args: + - /bin/sh + - -c + - "./hack/apidiff.sh ./staging/src/k8s.io/code-generator/examples ./staging/src/k8s.io/client-go" + resources: + # Memory limits are derived from pull-kubernetes-verify, with less CPUs. + limits: + cpu: 2 + memory: 12Gi + requests: + cpu: 2 + memory: 12Gi + # A periodic job which shows API diffs for staging repos since the last release # might be useful. Not done yet.