From d7514b3010e2d945672a54293ed1d10ac3d2af8e Mon Sep 17 00:00:00 2001 From: oliver-goetz Date: Fri, 1 Dec 2023 14:59:37 +0100 Subject: [PATCH] Prevent clients created with `GitHubOptions.GitClientFactory` from leaking secrets --- prow/flagutil/github.go | 1 + 1 file changed, 1 insertion(+) diff --git a/prow/flagutil/github.go b/prow/flagutil/github.go index 06832a8c61b9..97a76e665f06 100644 --- a/prow/flagutil/github.go +++ b/prow/flagutil/github.go @@ -337,6 +337,7 @@ func (o *GitHubOptions) GitHubClientWithAccessToken(token string) (github.Client // github.go. func (o *GitHubOptions) GitClientFactory(cookieFilePath string, cacheDir *string, dryRun, persistCache bool) (gitv2.ClientFactory, error) { opts := gitv2.ClientFactoryOpts{ + Censor: secret.Censor, CookieFilePath: cookieFilePath, Host: o.Host, Persist: &persistCache,