Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build release notes for alpha.0 and beta.0 releases #1119

Closed
saschagrunert opened this issue Feb 20, 2020 · 6 comments
Closed

Build release notes for alpha.0 and beta.0 releases #1119

saschagrunert opened this issue Feb 20, 2020 · 6 comments
Assignees
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject kind/feature Categorizes issue or PR as related to a new feature. needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release.
Milestone

Comments

@saschagrunert
Copy link
Member

saschagrunert commented Feb 20, 2020

We should build the release notes for both alpha.0 and beta.0 releases as well which is currently not the case. This is also the reason why anago still removes the unnecessary CHANGELOG/CHANGELOG-x.y.md files from the release branch on its creation:

release/anago

Lines 561 to 573 in 3c23261

# Clear all CHANGELOG-N.NN.md files on the branch and insert the
# generated one, if # $PARENT_BRANCH==master, which seems to be in the
# weeks between branch creation the first official release of the branch.
# TODO: can this condition on whether the branch is "beta" or "rc" and be
# more simply readable to a maintainer?
if [[ "$PARENT_BRANCH" == "master" && "$branch" != "master" ]]; then
logecho -n "Remove any previous CHANGELOG-*.md files: "
logrun -s git rm -f "$CHANGELOG_DIR"/CHANGELOG-*.md || return 1
logecho -n "Copy master $CHANGELOG_FILEPATH to $branch branch: "
logrun -s git checkout master -- $CHANGELOG_FILEPATH || return 1
logecho -n "Committing deleted CHANGELOG-*.md files: "
logrun -s git commit -am "Delete extraneous CHANGELOG-*.md files on branch." || return 1
fi

This ☝️ code part should not be done by anago but the krel changelog command invocation to have a single point of responsibilities inside our tooling.

I suggest in keeping this issue open and address it after/during the migration of anago to krel.

Refers to #918

@saschagrunert saschagrunert added kind/feature Categorizes issue or PR as related to a new feature. sig/release Categorizes an issue or PR as relevant to SIG Release. area/release-eng Issues or PRs related to the Release Engineering subproject labels Feb 20, 2020
@saschagrunert saschagrunert added this to the v1.18 milestone Feb 20, 2020
@saschagrunert saschagrunert self-assigned this Feb 20, 2020
@xmudrii
Copy link
Member

xmudrii commented May 7, 2020

@saschagrunert What is the status of this issue? Should we move it away from the v1.18 milestone? Are you still interested to work on this one or should we reassign it?

@saschagrunert
Copy link
Member Author

@saschagrunert What is the status of this issue? Should we move it away from the v1.18 milestone? Are you still interested to work on this one or should we reassign it?

The work has not started yet. I guess we can tackle that issue when we're moving to a krel based anago version, which has been started in #1106

@xmudrii
Copy link
Member

xmudrii commented May 11, 2020

Thanks for the update! I'll move this issue to the v1.19 milestone for now.
/milestone v1.19

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 9, 2020
@saschagrunert
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 9, 2020
@saschagrunert
Copy link
Member Author

I think it is intended to not create release notes for those .0 alphas and betas. We only create them with the first alpha, because then we would actually have something to diff to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject kind/feature Categorizes issue or PR as related to a new feature. needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
None yet
Development

No branches or pull requests

4 participants