New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strings.ReplaceAll causes pull-kubernetes-kubemark-e2e-gce-big to fail on 1.13 #554

Closed

oxddr opened this issue Jun 4, 2019 · 0 comments · Fixed by #555

Assignees

Contributor

oxddr commented Jun 4, 2019

This was reported on slack: https://kubernetes.slack.com/archives/C09QZTRH7/p1559596507001600

strings.ReplaceAll was added in go1.12, but I suspect we still build clusterloader2 for stable versions using older version of golang.

/assign @oxddr
/cc @lbernail

k8s-ci-robot assigned oxddr

oxddr mentioned this issue

Use strings.Replace instead strings.ReplaceAll to keep compatibility with go1.11.5 #555

Merged

k8s-ci-robot closed this as completed in #555

oxddr mentioned this issue

REQUEST: New membership for oxddr kubernetes/org#891

Closed

6 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment