Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OpenLab Github app for kubernetes-sigs/cluster-api-provider-openstack #2580

Closed
sbueringer opened this issue Mar 16, 2021 · 8 comments
Closed
Labels
area/github-integration Third-party integrations, webhooks, or GitHub Apps

Comments

@sbueringer
Copy link
Member

sbueringer commented Mar 16, 2021

Organization or repository

kubernetes-sigs/cluster-api-provider-openstack

Name of integration

OpenLab Zuul (not sure what the exact name is)

Link to integration website

https://github.com/apps/theopenlab-ci

Describe what is attempting to be accomplished

We want to remove the integration because we're not using it anymore (we migrated to Prow instead for our conformance tests)

Additional context for request

P.S.Probably the wrong repo for this request, but: (If there's another place to ask please send me there :))

@nikhita
Copy link
Member

nikhita commented Mar 24, 2021

@sbueringer 👋 We generally defer to the repo admins for these actions.

We want to remove the integration because we're not using it anymore

Anyone from https://github.com/orgs/kubernetes-sigs/teams/cluster-api-provider-openstack-admins can remove the integration. If the admins list is stale, I'd recommend updating it by creating a PR against

cluster-api-provider-openstack-admins:

is there a way to delete accidentally pushed branches from the repo?

Yes, admins would need to delete the branch protection for the branch-to-be-deleted from https://github.com/kubernetes-sigs/cluster-api-provider-openstack/settings/branches. After that's done, they can delete the branch from https://github.com/kubernetes-sigs/cluster-api-provider-openstack/branches.

is there a way to make it possible to only push certain branches (with the rights (maintainer?) I currently have?)

There is no way to restrict which branches can be pushed if you have write access but fwiw I set git remote set-url --push upstream no_push to never push anything directly to the upstream repo.

https://github.com/kubernetes-sigs/cluster-api-provider-openstack/branches/all

https://github.com/orgs/kubernetes-sigs/teams/cluster-api-provider-openstack-admins should be able to do this too. 👍

Since repo admins can take action here, I'm going to close this issue but please feel free to reopen if you'd like the org admins to step in and help!

@nikhita nikhita closed this as completed Mar 24, 2021
@nikhita
Copy link
Member

nikhita commented Mar 24, 2021

...Actually, spoke too soon 😛

From the org admin side, we might need to clean up the integration entirely from the org. Removing the integration from the repo can be done by repo admins though. 👍

Reopening :)

@nikhita nikhita reopened this Mar 24, 2021
@sbueringer
Copy link
Member Author

@nikhita Thank you very much. git remote set-url --push upstream no_push should be enough for my use case.

Did I get it right that we have to first remove it from the repo and then one of the org admins would remove it from the organization?

Although I'm not sure if we want to remove it from the whole org, I don't know if anybody except us (cluster-api-provider-openstack) is using it in the kubernetes-sigs org.

@nikhita
Copy link
Member

nikhita commented Mar 24, 2021

Did I get it right that we have to first remove it from the repo and then one of the org admins would remove it from the organization?

Yes, that's correct.

Although I'm not sure if we want to remove it from the whole org, I don't know if anybody except us (cluster-api-provider-openstack) is using it in the kubernetes-sigs org.

I checked the org-level configuration, it's only cluster-api-provider-openstack that uses it, so it should be safe to completely remove it. 👍

@sbueringer
Copy link
Member Author

@nikhita I'm now a repo admin, but I don't see the uninstall button:
image

Could it be that repo admins are not allowed to remove integrations? (I see a lot of other stuff which suggest I am in fact admin now)

@nikhita
Copy link
Member

nikhita commented Mar 25, 2021

Could it be that repo admins are not allowed to remove integrations? (I see a lot of other stuff which suggest I am in fact admin now)

Yes, it looks like only org admins can do that. I'll check with other org admins once before uninstalling the integration entirely. Will report back once it's done. 👍

@nikhita
Copy link
Member

nikhita commented Mar 25, 2021

The OpenLab GitHub app has been uninstalled. For the record:

cluster-api-provider-openstack was the only repo that used this app:

Screenshot from 2021-03-25 16-30-03

First, I tried removing the repo only but it didn't allow me to do that:

Screenshot from 2021-03-25 16-30-16

Then I uninstalled the app completely:

Screenshot from 2021-03-25 16-30-28

Verified that this integration does not show up in the repo settings:

Screenshot from 2021-03-25 16-34-31

@nikhita nikhita closed this as completed Mar 25, 2021
@sbueringer
Copy link
Member Author

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/github-integration Third-party integrations, webhooks, or GitHub Apps
Projects
None yet
Development

No branches or pull requests

2 participants