Make sure to prepare the kic volume after creation #8777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The volume is created as empty, so make sure that we run a container to do the initial copy of /var from the image. This is to avoid race conditions later on, where the preload starts to use the created volume for packing up the tarball.
Now that there is no more race between the containers for preparing the volume, we can use it for podman as well... Previously we risked ending up with not copying the contents of /var from the container image, which made it not work.
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
|
kvm2 Driver |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verified manually that it works, with both the docker and the podman drivers (new feature).
But only left the most basic
test -d /var/libcheck, so we are free to change the base image.Also confirmed that a simple "touch" in the volume is enough to throw the error at boot.
Note that this new "docker run" command is run before we run the other two in parallel.
Closes #8179 #8100