-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move machine and drivers to minikube repositories #9952
Comments
Since we download the drivers ourselves now, users don't actually need to notice much. We just have to make sure to use the same feature, also for "vmware" and "parallels". |
We probably need a separate github organization for this, just for minikube ? Could also be used to gather some of the personal repositories currently used. |
I am okay with moving it to minikube, it would be less complicated release and code review |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
I'm not sure to fully understand the target.
Can you provide an update about this issue ? |
Current patches for the "virtualbox" driver:
https://github.com/machine-drivers/machine/tree/master/drivers/virtualbox Current patches for the "hyperv" driver:
https://github.com/machine-drivers/machine/tree/master/drivers/hyperv The "none" driver has been forked, to the "none" driver. https://github.com/kubernetes/minikube/tree/master/pkg/drivers/none The "generic" driver has been forked, to the "ssh" driver. https://github.com/kubernetes/minikube/tree/master/pkg/drivers/ssh |
We don't know how long the docker/machine and machine-drivers organization will stay active.
Both docker/machine and boot2docker/boot2docker are deprecated and dead since 2019.
So there is no release for Docker 20.10 and later releases, and eventually they might disappear.
We need to maintain our own fork of the git repos, until it can be integrated more into minikube.
This affect the current repositories:
github.com/docker/machine -->
github.com/machine-drivers/machine
github.com/boot2docker/boot2docker -->
github.com/machine-drivers/boot2dockergithub.com/dhiltgen/docker-machine-kvm -->
github.com/machine-drivers/docker-machine-kvmgithub.com/machine-drivers/docker-machine-driver-libvirtgithub.com/machine-drivers/docker-machine-driver-hyperkitgithub.com/docker/machine/drivers/vmwarefusiongithub.com/machine-drivers/docker-machine-driver-vmware
github.com/Parallels/docker-machine-parallels -->
github.com/machine-drivers/docker-machine-parallels
See also #9805 about different architectures
We are currently in the process of converting all the drivers to (incompatible) minikube versions.
So far we have done the "kvm" and the "none" drivers, and are about to do the "generic" driver.
We also have patches to the "hyperv" and "hyperkit" drivers, so they are not identical either...
At some point, we need to stop naming the binaries as
docker-machine-driver
whatsoever.We should break out the kvm and hyperkit drivers from the "minikube" source code repository,
and set them up with build infrastructure like these other two external (not compiled in) drivers.
Currently they are making the Makefile and other files for minikube needlessly complicated,
since they need to be cross-compiled and add dependencies to native libraries and so on.
See #9583
Internal drivers:
External drivers:
Note that docker and podman are not (real) libmachine drivers.
All minikube driver names are hardcoded into the main binary.
The text was updated successfully, but these errors were encountered: