minikube_latest_amd64.deb accidentally included in Github release assets

[thetillhoff]

When checking through the release assets of the last release (https://github.com/kubernetes/minikube/releases/tag/v1.13.1), I found that there are two .deb files for the same thing:

• minikube_latest_amd64.deb
• minikube_1.13.1-0_amd64.deb

IMO the latest one shouldn't be there, since the path to it is still versioned as https://github.com/kubernetes/minikube/releases/download/v1.13.1/minikube_latest_amd64.deb.

Since I haven't found the corresponding pipeline so far, maybe you could/should look into this.

[afbjorklund]

It’s just to make the URL in the documentation ”static” (latest)
It’s the exact same content as in the “normal” packages (which in turn is identical to the uncompressed binary)

[afbjorklund]

See #7971

[tstromberg]

This is a bug. The latest artifact is indeed intended for static URL's, but it shouldn't be part of the GitHub release. These unversioned files should get filtered out from here:

minikube/hack/jenkins/release_github_page.sh

Line 84 in 11cad2b

for file in out/minikube[_-]* out/docker-machine-*; do

[afbjorklund]

Right, the docs* says to get it from google and not github...

* https://minikube.sigs.k8s.io/docs/start/

[thetillhoff]

I would love to work on this. Will start tomorrow.

[thetillhoff]

Short note: minikube-latest.x86_64.rpm is also excluded now.

[thetillhoff]

This is a bug. The latest artifact is indeed intended for static URL's, but it shouldn't be part of the GitHub release. These unversioned files should get filtered out from here:

minikube/hack/jenkins/release_github_page.sh

Line 84 in 11cad2b

for file in out/minikube[_-]* out/docker-machine-*; do

@tstromberg Thank you for pointing there, that saved me a lot of time 🥇