Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "new version of minikube" message shouldn't have the type io.k8s.sigs.minikube.error #9108

Closed
jtzwu opened this issue Aug 27, 2020 · 4 comments · Fixed by #9109
Closed
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@jtzwu
Copy link
Contributor

jtzwu commented Aug 27, 2020

Steps to reproduce the issue:

  1. Run minikube start --output=json

Full output of minikube start command used, if not already included:
...
{'data': {'message': 'minikube 1.12.3 is available! Download it: https://github.com/kubernetes/minikube/releases/tag/v1.12.3\n'}, 'datacontenttype': 'application/json', 'id': '561b5628-0fac-487d-b5fd-028a4c63503a', 'source': 'https://minikube.sigs.k8s.io/', 'specversion': '1.0', 'type': 'io.k8s.sigs.minikube.error'}

@tstromberg tstromberg added the kind/bug Categorizes issue or PR as related to a bug. label Aug 27, 2020
@vinu2003
Copy link
Contributor

/assign @vinu2003

@vinu2003
Copy link
Contributor

vinu2003 commented Aug 28, 2020

@tstromberg just wanted to confirm even the below one type shouldn't be io.k8s.sigs.minikube.error correct ?

{"data":{"message":"/home/vinu/go_workspace/bin/kubectl is version 1.20.0-alpha.0.188+65a1f24b205ece-dirty, which may be incompatible with Kubernetes 1.18.3.\n"},"datacontenttype":"application/json","id":"f6ee3909-ef29-4667-8f46-951427b4314a","source":"https://minikube.sigs.k8s.io/","specversion":"1.0","type":"io.k8s.sigs.minikube.warning"}

{"data":{"message":"You can also use 'minikube kubectl -- get pods' to invoke a matching version\n"},"datacontenttype":"application/json","id":"51d20524-d797-4f98-a452-0d2e6a84fb33","source":"https://minikube.sigs.k8s.io/","specversion":"1.0","type":"io.k8s.sigs.minikube.error"}

I might be wrong. Please ignore if i am wrong here.
The above messages are seen when the Kubectl clientMajor version != Cluster Major version OR the minor version of both is greater than 1.

@tstromberg
Copy link
Contributor

@vinu2003 - Your right, that does not sound like an error either. Do you mind sending a PR for it?

@vinu2003
Copy link
Contributor

vinu2003 commented Sep 2, 2020

Sure I will send it @tstromberg. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants