Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: add a flag to disable Minikube's update messaging #7181

Closed
etanshaul opened this issue Mar 23, 2020 · 2 comments · Fixed by #7482
Closed

Feature request: add a flag to disable Minikube's update messaging #7181

etanshaul opened this issue Mar 23, 2020 · 2 comments · Fixed by #7482
Labels
kind/feature Categorizes issue or PR as related to a new feature. ux/embedded Embedded UX blockers

Comments

@etanshaul
Copy link

Something like minikube start --wantUpdateNotification=false

Example:

* minikube 1.8.2 is available! Download it: https://github.com/kubernetes/minikube/releases/tag/v1.8.2
* To disable this notice, run: 'minikube config set WantUpdateNotification false'

For use-cases of driving Minikube from other tools - where the Minikube dependency is managed - it would be incredibly helpful to be able to pass in a flag to minikube to disable this update message, instead of setting a global config.

@etanshaul
Copy link
Author

@tstromberg brought the MINIKUBE_WANTUPDATENOTIFICATION flag to my attention which would satisfy our use-case: https://minikube.sigs.k8s.io/docs/reference/environment_variables/

Will leave open for the team to decide if a this would be useful, still, as a flag.

@tstromberg tstromberg added ux/embedded Embedded UX blockers triage/discuss Items for discussion labels Mar 24, 2020
@priyawadhwa priyawadhwa added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 25, 2020
@tstromberg
Copy link
Contributor

I'm going to close it, since it's primarily used by tool builders who can encode this once rather than most users, so the extra cognitive overhead of seeing it in --start isn't worth it.

Historical note: this was made an environment variable because minikube used to show the update message on every command. I felt that was a bit obnoxious, so it only happens during start now.

Feel free to /reopen this issue if you disagree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. ux/embedded Embedded UX blockers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants