Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect connectivity problem to image repository before start #5570

Closed
medyagh opened this issue Oct 8, 2019 · 2 comments
Closed

detect connectivity problem to image repository before start #5570

medyagh opened this issue Oct 8, 2019 · 2 comments
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@medyagh
Copy link
Member

medyagh commented Oct 8, 2019

rather than spinning up minikube and wait and retry and then crashing it would be nicer,
if minikube tries to ping or check the network connectivity to gcr (or whatever image repository specified) and if it there is no network connection minikube should nicely not continue and recommend the user to start with correct image-repos options

related:

#5531

@medyagh medyagh added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. labels Oct 8, 2019
@medyagh medyagh changed the title detect connectivty problem to image repository early detect connectivity problem to image repository before start Oct 8, 2019
@brennerm
Copy link

brennerm commented Oct 9, 2019

Not sure if that check is properly executable. Think about a case where the machine that runs minikube is not able to reach the registry but by using e.g. the --kvm-qemu-uri or --kvm-network flag the VM would eventually be able to.

In this case you would still need to start the VM and execute the check afterwards. Alternatively you could execute the check locally and make it skippable with a flag. Let me know what you think.

@RA489
Copy link

RA489 commented Oct 10, 2019

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

No branches or pull requests

3 participants