Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update-context is confusing with profiles: "IP was already configured" #3983

Closed
tstromberg opened this issue Mar 26, 2019 · 1 comment · Fixed by #4049
Closed

update-context is confusing with profiles: "IP was already configured" #3983

tstromberg opened this issue Mar 26, 2019 · 1 comment · Fixed by #4049
Labels
area/profiles issues related to profile handling kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@tstromberg
Copy link
Contributor

$ ./out/minikube update-context -p minikube
🙄  IP was already correctly configured for 192.168.39.232

$ kubectl config view | grep current
current-context: v1134

$ ./out/minikube update-context -p v1134
🙄  IP was already correctly configured for 192.168.39.241

$ kubectl config view | grep current
current-context: v1134

Notice how the context never changes, but minikube thinks it is already correctly configured?

@tstromberg tstromberg added this to the v1.0.0 milestone Mar 26, 2019
@tstromberg
Copy link
Contributor Author

I think this is just a case of confusing output. "update-context" shouldn't update the current kubectl context.

If the message simply output the name of the profile, it would seem correct.

@tstromberg tstromberg changed the title update-context non-functional: "was already configured for <IP>" update-context is confusing with profiles: "IP was already configured" Mar 26, 2019
@tstromberg tstromberg removed this from the v1.0.0 milestone Mar 27, 2019
@tstromberg tstromberg added priority/backlog Higher priority than priority/awaiting-more-evidence. area/profiles issues related to profile handling kind/bug Categorizes issue or PR as related to a bug. labels Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/profiles issues related to profile handling kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant