Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debian package should include the kvm driver (docker-machine-driver-kvm2) #2982

Closed
marcominetti opened this issue Jul 14, 2018 · 15 comments
Closed
Labels
area/build-release co/kvm2-driver KVM2 driver related issues help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. os/linux packaging Packaging issues priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. r/2019q2 Issue was last reviewed 2019q2
Milestone

Comments

@marcominetti
Copy link

Is this a BUG REPORT or FEATURE REQUEST?: FEATURE REQUEST

The minikube-XXX-.deb package is intended to be used on debian systems. To simplify setup and usage of kvm2 driver, it could be include within the package (maybe provided through private debian repository). Thus the installation and upgrade of minikube will be more convenient.

Please provide the following details:

Environment: Linux

Minikube version: 0.27 and 0.28

  • OS : Ubuntu 18.04
  • VM Driver: KVM2

What happened:
I need to install and maintain (upgrade) docker-machine-driver-kvm2 manually as sudoer.

What you expected to happen:
Installing/upgrading the minikube through debian package, the docker-machine-driver-kvm2 is installed/upgraded accordingly.

@idvoretskyi
Copy link
Member

+1, I second this.

@tstromberg tstromberg added packaging Packaging issues kind/feature Categorizes issue or PR as related to a new feature. os/linux co/kvm2-driver KVM2 driver related issues labels Sep 18, 2018
@nmabhinandan
Copy link

+1

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 20, 2019
@tstromberg tstromberg added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 24, 2019
@afbjorklund
Copy link
Collaborator

I suppose removing the .deb altogether is another option ? Then it could be packaged properly downstream instead, using PPA or some similar means. And then wouldn't have to defend the lack of .rpm etc (#402)

@afbjorklund
Copy link
Collaborator

If we packaged kvm2 as debs, maybe that could avoid versioning issues: #3437

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 7, 2019
@tstromberg tstromberg added the r/2019q2 Issue was last reviewed 2019q2 label May 22, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 21, 2019
@mgabeler-lee-6rs
Copy link

/remove-lifecycle rotten

This is still very desirable for Debian-based systems.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jun 21, 2019
@afbjorklund
Copy link
Collaborator

afbjorklund commented Jun 22, 2019

@mgabeler-lee-6rs : note that virtualbox is still the default driver

Added some .deb packaging now, but it is not a hard dependency

We could add it as a soft: Suggests: docker-machine-driver-kvm2

@mgabeler-lee-6rs
Copy link

Given vbox as the default driver, Suggests seems like the right relation, yes.

Thanks for this!

@afbjorklund
Copy link
Collaborator

afbjorklund commented Jul 6, 2019

Most likely we will need to set up our own apt repository for this to work...

Similar to what is available for kubeadm (but not for bionic, just yet?)

https://kubernetes.io/docs/setup/production-environment/tools/kubeadm/install-kubeadm/#installing-kubeadm-kubelet-and-kubectl

curl -s https://packages.cloud.google.com/apt/doc/apt-key.gpg | apt-key add -
cat <<EOF >/etc/apt/sources.list.d/kubernetes.list
deb https://apt.kubernetes.io/ kubernetes-xenial main
EOF

See #3110

We also need to fix minikube build so that it actually builds it for xenial.

Currently there is a bug (#4555), so it bypasses docker and uses host. ☹

Update: fixed! Now building properly towards libvirt 1.3.1, so it works "everywhere"

FROM gcr.io/gcp-runtimes/ubuntu_16_0_4

@idvoretskyi
Copy link
Member

Most likely we will need to set up our own apt repository for this to work...

It's a great idea.

@justaugustus
Copy link
Member

justaugustus commented Jul 17, 2019

Linking the conversation in #wg-k8s-infra, so that context doesn't get lost on apt/yum repos: https://kubernetes.slack.com/archives/CCK68P2Q2/p1562665049225800

@afbjorklund
Copy link
Collaborator

afbjorklund commented Jul 17, 2019

@justaugustus : thanks for the link, but wasn't sure about the full context of the request
i.e. if minikube was to be included in the main repo, or set up a similar one for the project ?

We will start producing the packages for next release, so there should be some made for 1.3.0
Of course we already have the minikube packages, this was for docker-machine-driver-kvm2

@tstromberg tstromberg added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Aug 6, 2019
@afbjorklund
Copy link
Collaborator

@afbjorklund afbjorklund added this to the v1.3.0 milestone Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build-release co/kvm2-driver KVM2 driver related issues help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. os/linux packaging Packaging issues priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. r/2019q2 Issue was last reviewed 2019q2
Projects
None yet
Development

No branches or pull requests

9 participants