Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

containerd package has the same tarball checksum problems as others #13193

Closed
afbjorklund opened this issue Dec 18, 2021 · 7 comments
Closed
Labels
area/build-release area/guest-vm General configuration issues with the minikube guest VM lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@afbjorklund
Copy link
Collaborator

afbjorklund commented Dec 18, 2021

Building the ISO fails, since the upstream git archive randomly changes checksum.

This is due to including vendor/k8s.io/client-go/pkg/version/.gitattributes

base.go export-subst

The substitution will corrupt the git archive, by filling the git info with wrong information.

58,59c58,59
< 	gitVersion   string = "v0.0.0-master+$Format:%h$"
< 	gitCommit    string = "$Format:%H$" // sha1 from git, output of $(git rev-parse HEAD)
---
> 	gitVersion   string = "v0.0.0-master+1e5ef943eb"
> 	gitCommit    string = "1e5ef943eb76627a6d3b6de8cd1ef6537f393a71" // sha1 from git, output of $(git rev-parse HEAD)

It was intended to record the kubernetes version, but here has a random short rev of containerd.

Problems started with containerd 1.5.x, that started including k8s.io/client-go (unlike 1.4.x)

@afbjorklund
Copy link
Collaborator Author

afbjorklund commented Dec 18, 2021

Broke the ISO build in PR #13089

@afbjorklund
Copy link
Collaborator Author

afbjorklund commented Dec 18, 2021

@afbjorklund afbjorklund added area/guest-vm General configuration issues with the minikube guest VM area/build-release labels Dec 18, 2021
This was referenced Dec 18, 2021
@spowelljr spowelljr added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Jan 27, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 27, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 27, 2022
@sharifelgamal sharifelgamal removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jun 1, 2022
@sharifelgamal
Copy link
Collaborator

Yeah, we've seen this happen on occasion for containerd and crio, not a whole lot we can do about it except fix the hash for the time being.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 30, 2022
@afbjorklund
Copy link
Collaborator Author

Fixed in containerd 1.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build-release area/guest-vm General configuration issues with the minikube guest VM lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

5 participants