Windows Installer: the version should not be quoted

[elvisbort]

After installing Minikube, in the Windows Control Panel the Version appears with double quotes:

With double quotes, some tools get confused. For instance, winget wrongly detects an available upgrade:

Probably, removing the quotes would allow a little better user experience. Also, the quotes could be removed from further fields such as the "Publisher" one.

[elvisbort]

Maybe the following patch does suffice:

diff --git a/installers/windows/minikube.nsi b/installers/windows/minikube.nsi
index 03fe6d522..941037b8a 100644
--- a/installers/windows/minikube.nsi
+++ b/installers/windows/minikube.nsi
@@ -142,11 +142,11 @@ Section "Install"
 	WriteRegStr HKLM "${UNINSTALLDIR}" "QuietUninstallString" "$\"$INSTDIR\uninstall.exe$\" /S"
 	WriteRegStr HKLM "${UNINSTALLDIR}" "InstallLocation" "$\"$INSTDIR$\""
 	WriteRegStr HKLM "${UNINSTALLDIR}" "DisplayIcon" "$\"$INSTDIR\logo.ico$\""
-	WriteRegStr HKLM "${UNINSTALLDIR}" "Publisher" "$\"${COMPANYNAME}$\""
-	WriteRegStr HKLM "${UNINSTALLDIR}" "HelpLink" "$\"${HELPURL}$\""
-	WriteRegStr HKLM "${UNINSTALLDIR}" "URLUpdateInfo" "$\"${UPDATEURL}$\""
-	WriteRegStr HKLM "${UNINSTALLDIR}" "URLInfoAbout" "$\"${ABOUTURL}$\""
-	WriteRegStr HKLM "${UNINSTALLDIR}" "DisplayVersion" "$\"${VERSIONMAJOR}.${VERSIONMINOR}.${VERSIONBUILD}$\""
+	WriteRegStr HKLM "${UNINSTALLDIR}" "Publisher" "${COMPANYNAME}"
+	WriteRegStr HKLM "${UNINSTALLDIR}" "HelpLink" "${HELPURL}"
+	WriteRegStr HKLM "${UNINSTALLDIR}" "URLUpdateInfo" "${UPDATEURL}"
+	WriteRegStr HKLM "${UNINSTALLDIR}" "URLInfoAbout" "${ABOUTURL}"
+	WriteRegStr HKLM "${UNINSTALLDIR}" "DisplayVersion" "${VERSIONMAJOR}.${VERSIONMINOR}.${VERSIONBUILD}"
 	WriteRegDWORD HKLM "${UNINSTALLDIR}" "VersionMajor" ${VERSIONMAJOR}
 	WriteRegDWORD HKLM "${UNINSTALLDIR}" "VersionMinor" ${VERSIONMINOR}
 	

[RA489]

/kind support

[spowelljr]

Hi @elvisbort, thanks for reporting this issue with minikube!

This is definitely not intended and should be fixed.

We are open to anyone that's interested in helping with this issue!

[hiroyaonoe]

/assign @hiroyaonoe