Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestPause/serial/Pause failing #12284

Closed
medyagh opened this issue Aug 16, 2021 · 6 comments · Fixed by #13783
Closed

TestPause/serial/Pause failing #12284

medyagh opened this issue Aug 16, 2021 · 6 comments · Fixed by #13783
Assignees
Labels
kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone

Comments

@medyagh
Copy link
Member

medyagh commented Aug 16, 2021

https://storage.googleapis.com/minikube-builds/logs/master/20006/Docker_Linux_containerd.html#fail_TestPause%2fserial%2fPause

	I0814 09:37:19.058238  164716 ssh_runner.go:149] Run: sudo runc --root /run/containerd/runc/k8s.io pause 0fcd2105780a328964f9c30e4fc83c19689d1d0a6aac05dea8ef621aa6bb0216
	I0814 09:37:19.073009  164716 ssh_runner.go:149] Run: sudo runc --root /run/containerd/runc/k8s.io pause 0fcd2105780a328964f9c30e4fc83c19689d1d0a6aac05dea8ef621aa6bb0216 66b515b3e4a14fa94b7c66bf716bbb6b1a292a0066cd3bd9aa09cd86441b0a97
	I0814 09:37:19.085378  164716 retry.go:31] will retry after 276.165072ms: runc: sudo runc --root /run/containerd/runc/k8s.io pause 0fcd2105780a328964f9c30e4fc83c19689d1d0a6aac05dea8ef621aa6bb0216 66b515b3e4a14fa94b7c66bf716bbb6b1a292a0066cd3bd9aa09cd86441b0a97: Process exited with status 1
	stdout:
	Incorrect Usage.
	
	NAME:
	   runc pause - pause suspends all processes inside the container
	
	USAGE:
	   runc pause <container-id>
	
	Where "<container-id>" is the name for the instance of the container to be
	paused. 
	
	DESCRIPTION:
	   The pause command suspends all processes in the instance of the container.
	
	Use runc list to identify instances of containers and their current status.
	
	stderr:
	time="2021-08-14T09:37:19Z" level=error msg="runc: \"pause\" requires exactly 1 argument(s)"
	I0814 09:37:19.361816  164716 ssh_runner.go:149] Run: sudo systemctl is-active --quiet service kubelet
	I0814 09:37:19.371957  164716 pause.go:50] kubelet running: false
	I0814 09:37:19.371999  164716 ssh_runner.go:149] Run: sudo systemctl disable --now kubelet

@medyagh
Copy link
Member Author

medyagh commented Aug 17, 2021

could it be the "runc" changed the api to no longer accept Multiple containers to be Paused with one command ?

sudo runc --root /run/containerd/runc/k8s.io pause 0fcd2105780a328964f9c30e4fc83c19689d1d0a6aac05dea8ef621aa6bb0216 66b515b3e4a14fa94b7c66bf716bbb6b1a292a0066cd3bd9aa09cd86441b0a97

@afbjorklund
Copy link
Collaborator

afbjorklund commented Aug 17, 2021

Yes, it seems the API was changed: opencontainers/runc@e0c7b6c

we think it's a bad idea to allow multi container operations in runc

@medyagh
Copy link
Member Author

medyagh commented Aug 17, 2021

so maybe we should change our code to Run it one at a time

@spowelljr spowelljr added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Aug 24, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 22, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 22, 2021
@sharifelgamal sharifelgamal added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Dec 22, 2021
@sharifelgamal sharifelgamal added this to the 1.26.0-candidate milestone Dec 22, 2021
@sharifelgamal
Copy link
Collaborator

Our pause tests are by far our flakiest ones, we should make it a priority to fix them soon.

@spowelljr spowelljr added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Feb 23, 2022
@spowelljr spowelljr self-assigned this Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants