Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cri-dockerd (and crictl) to installation #12103

Closed
afbjorklund opened this issue Aug 3, 2021 · 4 comments
Closed

Add cri-dockerd (and crictl) to installation #12103

afbjorklund opened this issue Aug 3, 2021 · 4 comments
Labels
co/runtime/docker Issues specific to a docker runtime kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@afbjorklund
Copy link
Collaborator

afbjorklund commented Aug 3, 2021

Docker is not enough after Kubernetes 1.23, also need to install cri-dockerd (and crictl).

https://www.mirantis.com/blog/the-future-of-dockershim-is-cri-dockerd/

Use the static binary for ISO

Use the deb package for KIC


This is needed for PR #12102 to work

There are no cri-dockerd releases yet

https://github.com/Mirantis/cri-dockerd/releases

There is a Makefile with a few targets. make deb or make rpm will probably have you covered, and you can install the packages as normal. If you’re using a different distribution, make static will give you raw binaries you can invoke.

@afbjorklund afbjorklund added kind/feature Categorizes issue or PR as related to a new feature. co/runtime/docker Issues specific to a docker runtime priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Aug 3, 2021
@afbjorklund

This comment has been minimized.

@afbjorklund
Copy link
Collaborator Author

afbjorklund commented Aug 4, 2021

Currently we install "cri-tools" from Kubic project, but might want to get that from upstream.

Sadly no deb packages are available there, but there is some kind of static binary tarball ?

https://kubernetes.io/docs/tasks/debug-application-cluster/crictl/

https://github.com/kubernetes-sigs/cri-tools

PS: "cri-tools" are crictl and critest


Note: cri-tools (crictl) is also needed for containerd (#11327), not only for cri-o

It's just that in the default containerd.io installation, cri is disabled (for docker).

/etc/containerd/config.toml

#   Copyright 2018-2020 Docker Inc.

#   Licensed under the Apache License, Version 2.0 (the "License");
#   you may not use this file except in compliance with the License.
#   You may obtain a copy of the License at

#       http://www.apache.org/licenses/LICENSE-2.0

#   Unless required by applicable law or agreed to in writing, software
#   distributed under the License is distributed on an "AS IS" BASIS,
#   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
#   See the License for the specific language governing permissions and
#   limitations under the License.

disabled_plugins = ["cri"]

...

Which is why the kubernetes documentation says to start by wiping the config for it:

containerd config default | sudo tee /etc/containerd/config.toml

https://kubernetes.io/docs/setup/production-environment/container-runtimes/#containerd

@afbjorklund
Copy link
Collaborator Author

afbjorklund commented Aug 6, 2021

Current hack:

make static-linux
minikube cp packaging/static/build/linux/cri-dockerd/cri-dockerd minikube:/usr/bin/cri-dockerd
minikube cp packaging/systemd/cri-docker.socket minikube:/usr/lib/systemd/system/cri-docker.socket
minikube cp packaging/systemd/cri-docker.service minikube:/usr/lib/systemd/system/cri-docker.service

https://github.com/Mirantis/cri-dockerd

Note: need to patch the systemd units:

https://github.com/Mirantis/cri-dockerd/commit/9ce92f8dc76aaa838538bc97a40f1fc2d82d2ef0.patch
https://github.com/Mirantis/cri-dockerd/commit/96fd1a7abdc575efd59ff184ef0535d518fba11a.patch

@afbjorklund
Copy link
Collaborator Author

Gave up on binaries (tarballs and packages), building from source.

Currently identifies itself as "0.2.0-dev" (Mirantis/cri-dockerd@542e27d)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
co/runtime/docker Issues specific to a docker runtime kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

No branches or pull requests

1 participant