-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exit with error when Docker version is too old #11543
Comments
Related to #9077
|
Another option is to remind the user to upgrade Docker when commands like |
/kind support |
We should bump the required version for the Docker driver to 2018, and leave the old versions only for the container runtime... We don't want to spend all resources "supporting" old deprecated versions of Docker and Podman, when even upstream doesn't. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
Let's add this back in soon. |
@dinever are u interested in this PR ? |
#10369 dropped the error in the Docker version validation to support old Docker versions.
With this change, the users get a confusing
docker info --format : exit status 2
error when they're using ancient Docker versions (<1.13.0) that don't even supportdocker info --version
, see#11480
#11538
Should we exit with an error and tell users to upgrade their Docker version when it's way too old?
One option is to define two constants:
minDockerVer
(e.g. 1.13.0) andrecommendedDockerVer
(18.09.0):minDockerVer
: Exit with error messagerecommendedDockerVer
: Only show suggestions to upgrade DockerrecommendedDockerVer
: Do nothingThe text was updated successfully, but these errors were encountered: