Disable mount propagation for windows containers #60275
Conversation
k8s-ci-robot
added
release-note
|
/sig windows |
k8s-ci-robot
added
the
sig/windows
feiskyer
added
the
priority/important-soon
|
/sig node |
k8s-ci-robot
added
the
sig/node
|
I approved this PR , but please also modify the documentation at https://kubernetes.io/docs/getting-started-guides/windows/ to add this at the bottom under known limitations |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
| @@ -272,6 +272,12 @@ func makeMounts(pod *v1.Pod, podDir string, container *v1.Container, hostName, h | |||
| // translateMountPropagation transforms v1.MountPropagationMode to | |||
| // runtimeapi.MountPropagation. | |||
| func translateMountPropagation(mountMode *v1.MountPropagationMode) (runtimeapi.MountPropagation, error) { | |||
| if runtime.GOOS == "windows" { | |||
There was a problem hiding this comment.
I am expecting we have more like this coming. Can you add a TODO to make this kind of Windows specific configuration / tuning can be easily managed? I don't want things like this scattered everywhere in our codebase, but can live with it for now with a TODO to unblock our progress.
There was a problem hiding this comment.
Ok, I filed #60338 as a record, so that we can process your pr asap.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dchen1107, feiskyer, michmike The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Automatic merge from submit-queue (batch tested with PRs 60054, 60202, 60219, 58090, 60275). If you want to cherry-pick this change to another branch, please follow the instructions here. |
What this PR does / why we need it:
Windows containers don't support mount propagation. This PR disables it for windows containers.
Without this PR, windows containers creation would fail with error:
Error: Error response from daemon: invalid bind mount spec "c:\var\lib\kubelet\pods\a260a7c4-1852-11e8-bb1d-000d3a19c1da\volumes\kubernetes.io
secret\default-token-rj7qv:c:/var/run/secrets/kubernetes.io/serviceaccount:ro,rslave": invalid volume specification: 'c:\var\lib\kubelet\pods\a260a7c4-1852-11e8-bb1d-000d3a19c1da\volumes\kubernetes.iosecret\default-token-rj7qv:c:\var\run\secrets\kubernetes.io\serviceaccount:ro,rslave'Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #60274
Special notes for your reviewer:
Release note: