Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pod updates:how to change the fields of spec.containers[].resources.request.cpu(memory) #104737

Closed
thyn opened this issue Sep 2, 2021 · 5 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling.

Comments

@thyn
Copy link

thyn commented Sep 2, 2021

Is it possible to change request only without pod restart? I know about #24913. But requests seems to me to be safe to change

Example of usage:
We have blue green deployment. When new pods are starting they need few resources. When they switched to production poods need more resources (request only). After deployment all old pods would be active for some time with lower requests. To be sure everything is ok.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Sep 2, 2021
@k8s-ci-robot
Copy link
Contributor

@thyn: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Sep 2, 2021
@thyn
Copy link
Author

thyn commented Sep 2, 2021

/sig scheduling

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 2, 2021
@pacoxu
Copy link
Member

pacoxu commented Sep 3, 2021

/sig apps node
for traige
/kind feature

The current updateable fields:

// validate updateable fields:
// 1. spec.containers[*].image
// 2. spec.initContainers[*].image
// 3. spec.activeDeadlineSeconds
// 4. spec.terminationGracePeriodSeconds

And there is #102884 to fix this, the primary goal is allow to change container resource requests & limits without necessarily restarting the container. Would you check if kubernetes/enhancements#2273 can solve your problem?

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. kind/feature Categorizes issue or PR as related to a new feature. labels Sep 3, 2021
@thyn
Copy link
Author

thyn commented Sep 5, 2021

Thank you. It's what I need. Is any information about next version which will contain that necessary changes?

@thockin
Copy link
Member

thockin commented Sep 5, 2021

@thockin thockin closed this as completed Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling.
Projects
None yet
Development

No branches or pull requests

4 participants