Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graduate Bootstrap Tokens to GA #964

Closed
1 task done
neolit123 opened this issue Jul 4, 2018 · 14 comments
Closed
1 task done

Graduate Bootstrap Tokens to GA #964

neolit123 opened this issue Jul 4, 2018 · 14 comments
Assignees
@neolit123
Labels
area/security kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone
v1.18

Comments

@neolit123
Copy link
Member

neolit123 commented Jul 4, 2018 •
edited
Loading

bellow are remaining tasks after the recent discussions

we do not know of any remaining feature work for the feature to not be GA at this point.
code cleanup and moving bits around is a separate effort.

update kubernetes/kubernetes/cmd/kubeadm to not mention bootstrap tokens as Beta
EDIT: i cannot find any mentions of that

update kubernetes/website to not mention the tokens as Beta
assigned: @neolit123
@neolit123 neolit123 added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jul 4, 2018
@neolit123 neolit123 added this to the v1.12 milestone Jul 4, 2018
@timothysc timothysc assigned timothysc and unassigned luxas Aug 9, 2018
@neolit123 neolit123 mentioned this issue Aug 17, 2018
Closed
28 tasks
@timothysc timothysc modified the milestones: v1.12, v1.13 Aug 21, 2018
@timothysc
Copy link
Member

xref - kubernetes/kubernetes#67356

@timothysc timothysc added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Aug 27, 2018
@neolit123
Copy link
Member Author

moved to 1.13 according to the release team:
kubernetes/kubernetes#67356 (comment)

@neolit123 neolit123 modified the milestones: v1.12, v1.13 Sep 17, 2018
@timothysc
Copy link
Member

/assign @fabriziopandini

for cross coverage on token shuffling config work.

@timothysc
Copy link
Member

This is a pain but not super critical for 1.13 release given all the other work that is going on. This is definitely higher priority tech debt for 1.14

@timothysc timothysc modified the milestones: v1.13, v1.14 Nov 13, 2018
@neolit123 neolit123 added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jan 3, 2019
@neolit123
Copy link
Member Author

neolit123 commented Jan 3, 2019 •
edited
Loading

after the creation of this repo:
https://github.com/kubernetes/cluster-bootstrap

what are the remaining items for this tickets?

@neolit123 neolit123 removed the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Jan 3, 2019
@fabriziopandini
Copy link
Member

@neolit123
There are still some bootstrap-token utilities hosted in kubeadm codebase (e.g. under each config version there is bootstraptokenstring.go, probably there is also something else around the code).
My understanding is that we want to move those utilities - or at least of some of those utilities - by moving everything not kubeadm specific into https://github.com/kubernetes/cluster-bootstrap

@neolit123 neolit123 added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Feb 3, 2019
@timothysc timothysc removed this from the v1.14 milestone Feb 13, 2019
@neolit123 neolit123 added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Jul 2, 2019
@neolit123
Copy link
Member Author

given we cannot move BoostrapTokenString in 1.16 (v1beta3 will come in 1.17), moving to the 1.17 milestone.

@neolit123 neolit123 modified the milestones: v1.16, v1.17 Jul 12, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 10, 2019
@neolit123
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 10, 2019
@neolit123
Copy link
Member Author

neolit123 commented Oct 23, 2019 •
edited
Loading

/lifecycle frozen
the move is seeing objection here:
kubernetes/kubernetes#77669 (review)

possibly needs further discussion, whether this is the right thing to do.

@k8s-ci-robot k8s-ci-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Oct 23, 2019
@neolit123 neolit123 mentioned this issue Oct 23, 2019
Merged
@liggitt liggitt mentioned this issue Oct 23, 2019
Closed
@neolit123 neolit123 added kind/documentation Categorizes issue or PR as related to documentation. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Oct 25, 2019
@neolit123
Copy link
Member Author

updated OP with documentation update items.
also added help-wanted as these cleanups are trivial.

@neolit123 neolit123 added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Oct 25, 2019
@neolit123 neolit123 modified the milestones: v1.17, v1.18 Nov 19, 2019
@neolit123 neolit123 self-assigned this Jan 2, 2020
@neolit123 neolit123 added lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. and removed help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jan 2, 2020
@neolit123 neolit123 mentioned this issue Jan 2, 2020
Merged
@RA489
Copy link
Contributor

RA489 commented Jan 9, 2020

@neolit123 Anything remaining with this effort?

@neolit123
Copy link
Member Author

neolit123 commented Jan 9, 2020 •
edited
Loading

no, we are sending a docs update:
kubernetes/website#18428

we do not know of any remaining feature work for the feature to not be GA at this point.
code cleanup and moving bits around is a separate effort.

@neolit123
Copy link
Member Author

kubernetes/website#18428
merged.

closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neolit123 neolit123

Labels
area/security kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
v1.18
Development

No branches or pull requests
9 participants
@timothysc @neolit123 @fabriziopandini @luxas @dixudx @k8s-ci-robot @fejta-bot @liztio @RA489