Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create [Feature:kubeadm] e2e tests #456

Closed
luxas opened this issue Sep 15, 2017 · 10 comments · Fixed by kubernetes/kubernetes#62665
Closed

Create [Feature:kubeadm] e2e tests #456

luxas opened this issue Sep 15, 2017 · 10 comments · Fixed by kubernetes/kubernetes#62665
Assignees
@fabriziopandini @liztio
Labels
area/test kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
v1.11

Comments

@luxas
Copy link
Member

luxas commented Sep 15, 2017

...under test/e2e_kubeadm/ in the core kubernetes repo.
e2e tests here should for instance make sure that:

  • At least one node is tainted/labelled with node-role.kubernetes.io/master=""
  • cluster-info is exposed in a correct manner, and the right Role and RoleBinding exist
  • The right Node Bootstrap Token RBAC rules exist, the SAR approver is enabled, etc.
  • The kubeadm-config ConfigMap exists.
  • API Aggregation features are enabled
  • What else?

@timothysc @pipejakob Ideas?
@luxas luxas added area/test priority/backlog Higher priority than priority/awaiting-more-evidence. labels Sep 15, 2017
@luxas luxas added this to the v1.9 milestone Sep 15, 2017
@luxas luxas modified the milestones: v1.9, v1.10 Nov 18, 2017
@timothysc timothysc modified the milestones: v1.10, v1.11 Jan 24, 2018
@timothysc
Copy link
Member

So this requires segregating into it's own location for future forking.

@timothysc
Copy link
Member

/assign @fabriziopandini @liztio

This will be a requirement for some of the HA work in order to validate it.

@timothysc timothysc added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/feature Categorizes issue or PR as related to a new feature. and removed priority/backlog Higher priority than priority/awaiting-more-evidence. labels Apr 7, 2018
@liztio liztio added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Apr 12, 2018
@liztio
Copy link

liztio commented Apr 19, 2018

Can we clarify this a little more? What RBAC roles should be expected? What's the "correct manner" for cluster-info to be exposed? What node bootstrap token rules should exist?

@fabriziopandini
Copy link
Member

@liztio I think that this document can be a good starting point
https://kubernetes.io/docs/reference/setup-tools/kubeadm/implementation-details/#wait-for-the-control-plane-to-come-up.
If I got this right we have to check that kubeadm-- executes properly the steps starting from mark master.

Is there a WIP for this work?

@liztio
Copy link

liztio commented Apr 23, 2018

@fabriziopandini my WIP is kubernetes/kubernetes#62665.

I'm feeling a bit weird about this though... most of these things aren't really E2E tests, they're more like integration tests.

@timothysc
Copy link
Member

@liz I'm totally ok with getting what you have hooked up, and we can create a new tracking issue with a list. You could easily back-hole on this, and we could federate the work items across the SIG for this type of work.

@liztio liztio mentioned this issue Apr 23, 2018
Merged
@liztio
Copy link

liztio commented Apr 23, 2018

Also added kubernetes/test-infra#7833

k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this issue May 10, 2018
Merge pull request #62665 from liztio/kubeadm-e2e
8ce536d 
Automatic merge from submit-queue (batch tested with PRs 62665, 62194, 63616, 63672, 63450). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Kubeadm e2e

**What this PR does / why we need it**:

Provides in-tree E2E tests for the Kubeadm subproject

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes [kubeadm#456](kubernetes/kubeadm#456)

**Special notes for your reviewer**:

The weird way tests are executed mirrors `e2e_node`. A future pull request will add a frontend for these tests to kubetest, which will abstract away much of this detail.

**Release note**:
```release-note
NONE
```
@luxas
Copy link
Member Author

luxas commented May 11, 2018

Reopening until we've got these running automatically

@luxas luxas reopened this May 11, 2018
@timothysc
Copy link
Member

Per discussion, I think we should separate out the automation from the enablement so move to close.

@liztio
Copy link

liztio commented May 14, 2018

Closed in favor of #813

@liztio liztio closed this as completed May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fabriziopandini fabriziopandini

@liztio liztio

Labels
area/test kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
v1.11
Development

Successfully merging a pull request may close this issue.

Kubeadm e2e liztio/kubernetes
4 participants
@timothysc @fabriziopandini @luxas @liztio