Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add some refer for kubeadm operator #2909

Merged
merged 1 commit into from
Aug 2, 2023
Merged

add some refer for kubeadm operator #2909

merged 1 commit into from
Aug 2, 2023

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Jul 31, 2023

No description provided.

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 31, 2023
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 31, 2023
@pacoxu
Copy link
Member Author

pacoxu commented Jul 31, 2023

/test pull-kubeadm-kinder-upgrade-latest
/test pull-kubeadm-kinder-verify

1 similar comment
@pacoxu
Copy link
Member Author

pacoxu commented Jul 31, 2023

/test pull-kubeadm-kinder-upgrade-latest
/test pull-kubeadm-kinder-verify

chendave
chendave approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@chendave chendave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 1, 2023
@chendave
Copy link
Member

chendave commented Aug 1, 2023

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 1, 2023
@chendave
Copy link
Member

chendave commented Aug 1, 2023

I am not an approver yet.

/approve cancel

@chendave
Copy link
Member

chendave commented Aug 1, 2023

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 1, 2023
@SataQiu
Copy link
Member

SataQiu commented Aug 1, 2023

/lgtm
/retest

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacoxu, SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pacoxu
Copy link
Member Author

pacoxu commented Aug 2, 2023

/easycla
/check-cla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 2, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8a49b3b into kubernetes:main Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chendave chendave chendave approved these changes

@neolit123 neolit123 Awaiting requested review from neolit123

Assignees

@chendave chendave

@SataQiu SataQiu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pacoxu @chendave @SataQiu @k8s-ci-robot