-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create process for triaging/fixing kubeadm test failures #251
Comments
I think 1 will tie into the usual feedback cycle for PRs: if a PR build fails, the contributor can incorporate changes to get the e2e tests to pass again. That's their prerogative. For 2 I agree that it's the contributor who should take primary responsibility for calibrating their code with the existing suite of tests, regardless of whether they're unit or e2e, and making sure they verify the (new) state of the codebase. Ultimately it's the task of project maintainers to keep this in check, so they can be contacted for help whenever required. I'm also interested in formalising the contract between test-infra and SIGs. How is Also, where would this process doc live? In this repo's README or CONTRIBUTING.md? |
@pipejakob @jamiehannaford Sounds like we should create a document about this process... Are one of you up to doing that? |
I can have a go at writing this |
Awesome @jamiehannaford! |
Now that we have continuously running end-to-end tests, and the desire to add more, we should create a shared process that sets expectations for community members around who should triage and fix kubeadm, or the tests themselves, when they start failing.
Here are some of the scenarios that have already come up and could have benefited from a clear policy:
test-infra
code (e.g.bootstrap.py
,kubernetes_e2e.py
, etc.) breaks the kubeadm end-to-end tests.This is one of the action items from the 1.6.0 postmortem.
The text was updated successfully, but these errors were encountered: