Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubelet configuration should not be set defaults on kubeadm side. #1751

Closed
jfbai opened this issue Aug 25, 2019 · 1 comment
Closed

Kubelet configuration should not be set defaults on kubeadm side. #1751

jfbai opened this issue Aug 25, 2019 · 1 comment

Comments

@jfbai
Copy link

jfbai commented Aug 25, 2019

What keywords did you search in kubeadm issues before filing this one?

kubelet, configuration, default

Is this a BUG REPORT or FEATURE REQUEST?

BUG REPORT

Versions

kubeadm version (use kubeadm version): v1.14

Environment:

  • Kubernetes version (use kubectl version): v1.14
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Others:

What happened?

It is unable to customize readOnlyPort via kubeadm init phase upload-config kubelet --config kubeadm.yaml.

What you expected to happen?

readOnlyPort should be customizable via kubeadm init phase upload-config.

How to reproduce it (as minimally and precisely as possible)?

kubeadm init phase upload-config kubelet --config kubeadm.yaml

apiVersion: kubelet.config.k8s.io/v1beta1
kind: KubeletConfiguration
readOnlyPort: 10255

Anything else we need to know?

This is caused by kubeadm's default behaviour. But I think it would be better not to default the configurations on kubeadm side (even if it will be deprecated in the future), otherwise, it will break users' expectation.

@neolit123
Copy link
Member

closing in favor of: #1378
which already tracks this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants