Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the kubeadm upgrade test jobs #1230

Closed
neolit123 opened this issue Nov 12, 2018 · 3 comments
Closed

Fix the kubeadm upgrade test jobs #1230

neolit123 opened this issue Nov 12, 2018 · 3 comments
Assignees
@chuckha @neolit123 @detiber
Labels
area/test kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone
v1.15

Comments

@neolit123
Copy link
Member

neolit123 commented Nov 12, 2018 •
edited
Loading

The upgrade tests are facing a multitude of problems.
https://k8s-testgrid.appspot.com/sig-cluster-lifecycle-all

1 ginkgo is not skipping 3 tests that we want skipped:
https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm-upgrade.yaml#L157

can't tell if this is a kube-test vs ginkgo vs e2e framework bug.

2 kubernetes-anywhere 's paths in the e2e framework for old branches is bogus after we switched to pulling branches instead of specific commits in prow jobs:
kubernetes/kubernetes#70894
kubernetes/kubernetes#70895

3 we have actual failures in the [master-upgrade] tests:
https://gubernator.k8s.io/build/kubernetes-jenkins/logs/ci-kubernetes-e2e-kubeadm-gce-upgrade-stable-master/2831#master-upgrade-sig-cluster-lifecycle-master-upgrade

this PR:
#1224

and the two cherry picks above might fix these.

cc @timothysc @fabriziopandini
cc @kubernetes/sig-cluster-lifecycle

/assign
/kind failing-test
/priority important-longterm
/area testing
@neolit123 neolit123 added this to the v1.14 milestone Nov 12, 2018
@k8s-ci-robot k8s-ci-robot added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. area/test labels Nov 12, 2018
@timothysc
Copy link
Member

I want to push this onto cluster-api implementations TBH.

/assign @detiber @chuckha

@neolit123
Copy link
Member Author

i understand that there were previous attempts of solving the gingo skip issue. i will investigate as soon as i can myself.
my idea was to get these upgrade tests green until the cluster-api or kubespray setup is up.

@neolit123 neolit123 pinned this issue Jan 1, 2019
@fabriziopandini fabriziopandini unpinned this issue Jan 5, 2019
@timothysc timothysc modified the milestones: v1.14, v1.15 Feb 7, 2019
@neolit123
Copy link
Member Author

we no longer have to fix these, but rather remove them completely and use kind based upgrades.
moving the work here so that we don't have multiple tracking issues:
#1290

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chuckha chuckha

@neolit123 neolit123

@detiber detiber

Labels
area/test kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
v1.15
Development

No branches or pull requests
5 participants
@chuckha @timothysc @neolit123 @detiber @k8s-ci-robot