Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logr.Marshaler: does not handle non-string results #343

Closed
pohly opened this issue Aug 1, 2022 · 1 comment · Fixed by #344
Closed

logr.Marshaler: does not handle non-string results #343

pohly opened this issue Aug 1, 2022 · 1 comment · Fixed by #344
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@pohly
Copy link

pohly commented Aug 1, 2022

/kind bug

What steps did you take and what happened:

I wrote a MarshalLog implementation which returns a slice. klog called the function, but then logged the original value instead of the one returned by MarshaLog.

What did you expect to happen:

writeStringValue(b, false, fmt.Sprintf("%+v", v))
should log value, not v.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants