Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InfoS uses %#s for errors instead of %q #158

Closed
serathius opened this issue Jun 3, 2020 · 1 comment · Fixed by #159
Closed

InfoS uses %#s for errors instead of %q #158

serathius opened this issue Jun 3, 2020 · 1 comment · Fixed by #159
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@serathius
Copy link

/kind bug
When working on kubernetes/kubernetes#91591 we noticed that

klog.V(2).InfoS("NODE DENY", "err", err)

was serialized to

I0603 09:57:29.759232   53238 node_authorizer.go:209] "NODE DENY" err=&errors.errorString{s:"node \"node2\" cannot get secret ns1/node1-only, no relationship to this object was found in the node authorizer graph"}

instead of

I0603 09:57:29.759232   53238 node_authorizer.go:209] "NODE DENY" err="node \"node2\" cannot get secret ns1/node1-only, no relationship to this object was found in the node authorizer graph"

Possibly it was fixed by #156
If so we should add tests for Error objects.

@tahsinrahman
Copy link

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants