Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for proxy protocol in TCP services #930

Merged
merged 1 commit into from
Jul 2, 2017

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jul 2, 2017

fixes #659

Example:

apiVersion: v1
data:
  "9000": default/http-svc:80:PROXY
kind: ConfigMap
metadata:
  name: ingress-controller-tcp
  namespace: kube-system
     # TCP services
+    upstream tcp-default-http-svc-80 {
+        server                  172.17.0.3:8080;
+        server                  172.17.0.4:8080;
+    }
+
+    server {
+        listen                  9000 proxy_protocol;
+        listen                  [::]:9000 proxy_protocol;
+        proxy_pass              tcp-default-http-svc-80;
+    }

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 2, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@aledbf
Copy link
Member Author

aledbf commented Jul 2, 2017

ping @donaldguy
Test image: quay.io/aledbf/nginx-ingress-controller:0.158

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 44.299% when pulling 6a4679b on aledbf:proxy-tcp into 24d78ca on kubernetes:master.

@kubernetes kubernetes deleted a comment from coveralls Jul 2, 2017
@kubernetes kubernetes deleted a comment from coveralls Jul 2, 2017
@kubernetes kubernetes deleted a comment from coveralls Jul 2, 2017
@aledbf aledbf merged commit 7034712 into kubernetes:master Jul 2, 2017
@aledbf aledbf deleted the proxy-tcp branch July 6, 2017 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[nginx] TCP configmap should allow listen proxy_protocol per service
4 participants