Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add getenv #679

Merged
merged 1 commit into from
May 10, 2017
Merged

add getenv #679

merged 1 commit into from
May 10, 2017

Conversation

ckeyer
Copy link

@ckeyer ckeyer commented May 2, 2017

add template function getenv

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 2, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@ckeyer ckeyer force-pushed the template_getenv branch from b079905 to 52975eb Compare May 2, 2017 03:22
@coveralls
Copy link

Coverage Status

Coverage remained the same at 47.073% when pulling 52975eb73539729428105fe0b04124f6c4d84cec on ckeyer:template_getenv into f9663a8 on kubernetes:master.

@ckeyer ckeyer force-pushed the template_getenv branch 2 times, most recently from 6188e33 to b8c83f1 Compare May 2, 2017 03:33
@ckeyer ckeyer closed this May 2, 2017
@ckeyer ckeyer reopened this May 2, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 47.073% when pulling b8c83f12d028721b24370cad6b5b35669c69ece2 on ckeyer:template_getenv into f9663a8 on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 47.088% when pulling b8c83f12d028721b24370cad6b5b35669c69ece2 on ckeyer:template_getenv into f9663a8 on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 47.073% when pulling b8c83f12d028721b24370cad6b5b35669c69ece2 on ckeyer:template_getenv into f9663a8 on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 47.073% when pulling b8c83f12d028721b24370cad6b5b35669c69ece2 on ckeyer:template_getenv into f9663a8 on kubernetes:master.

@aledbf
Copy link
Member

aledbf commented May 2, 2017

@ckeyer please sign the CLA

@ckeyer ckeyer force-pushed the template_getenv branch from b8c83f1 to e9e8e72 Compare May 3, 2017 08:33
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 47.043% when pulling e9e8e7264a148ee2d804d291255ac5cb05daafb1 on ckeyer:template_getenv into f9663a8 on kubernetes:master.

@aledbf
Copy link
Member

aledbf commented May 5, 2017

@ckeyer please sign the CLA

@ckeyer ckeyer force-pushed the template_getenv branch 2 times, most recently from 440ac41 to 125b526 Compare May 7, 2017 04:31
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 47.139% when pulling 125b526d760a8fa8ce63c6cbeb2cf2dfc6b52073 on ckeyer:template_getenv into 4601775 on kubernetes:master.

@ckeyer ckeyer force-pushed the template_getenv branch from 125b526 to 7563bf1 Compare May 7, 2017 04:49
@coveralls
Copy link

Coverage Status

Coverage remained the same at 47.154% when pulling 7563bf1745a16d338be4fff663744995f1eee317 on ckeyer:template_getenv into 4601775 on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 47.139% when pulling 7563bf1745a16d338be4fff663744995f1eee317 on ckeyer:template_getenv into 4601775 on kubernetes:master.

Signed-off-by: Chuanjian Wang <[email protected]>
@ckeyer ckeyer force-pushed the template_getenv branch from 7563bf1 to 87b0584 Compare May 10, 2017 06:36
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 10, 2017
@ckeyer
Copy link
Author

ckeyer commented May 10, 2017

@aledbf PTAL

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 47.124% when pulling 87b0584 on ckeyer:template_getenv into 433220d on kubernetes:master.

@aledbf aledbf self-assigned this May 10, 2017
@aledbf
Copy link
Member

aledbf commented May 10, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2017
@aledbf
Copy link
Member

aledbf commented May 10, 2017

@ckeyer thanks!

@aledbf aledbf merged commit 317f222 into kubernetes:master May 10, 2017
@ckeyer ckeyer deleted the template_getenv branch May 11, 2017 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants