Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip validation when configmap is empty #441

Merged
merged 1 commit into from
Mar 14, 2017
Merged

skip validation when configmap is empty #441

merged 1 commit into from
Mar 14, 2017

Conversation

gianrubio
Copy link
Contributor

@gianrubio gianrubio commented Mar 14, 2017 •
edited
Loading

My bad on #432

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 14, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 43.114% when pulling 1e1e4dc on gianrubio:skip-validation into 153fdf5 on kubernetes:master.

@aledbf aledbf self-assigned this Mar 14, 2017
@aledbf
Copy link
Member

aledbf commented Mar 14, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2017
@aledbf aledbf merged commit 2f01845 into kubernetes:master Mar 14, 2017
gianrubio referenced this pull request Mar 15, 2017
@gianrubio
Validate if configmap exist and is in the namespace/name format
c6195c4 
Verifiy if watch-namespace option exist
@gianrubio gianrubio mentioned this pull request Mar 15, 2017
Closed
gianrubio added a commit to gianrubio/ingress that referenced this pull request Mar 15, 2017
@gianrubio
remove configmap validations . rollback kubernetes#441, fix kubernete…
3570d44 
…s#443
@gianrubio gianrubio mentioned this pull request Mar 15, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aledbf aledbf

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gianrubio @k8s-reviewable @coveralls @aledbf @k8s-ci-robot