Fix error caused by increasing proxy_buffer_size (#363) #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the bug raised in kubernetes#363, by increasing the size of the proxy_buffers (memory allocation) to match the size of the proxy buffer. This leaves the default values (with no ingress setting) unchanged: ``` proxy_buffer_size 4k proxy_buffers 4 4k ``` If 'proxy-buffer-size' is set, then now both the buffer size and the memory allocation size is increased: ``` proxy_buffer_size "{{ $location.Proxy.BufferSize }}"; proxy_buffers 4 "{{ $location.Proxy.BufferSize }}"; ``` I have been using this patch with 0.8.3 and 0.9.0-beta.2.
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@whereisaaron thanks! |
|
@whereisaaron Can you please let me know on how to apply this path to already running ingress controller? |
|
Apply a 'path' @NBCRB ? Do you mean 'patch'? If so, to apply it to a running ingress you'd need to update or edit the nginx template in the running container and make a change that triggers a reload. If you are not using a ConfigMap for the nginx template then that patch will be lost on container restart. Better idea is to do a rolling update of Ingress Controller instances to the new version with this patch included. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the bug raised in #363, by increasing the size of the proxy_buffers (memory allocation) to match the size of the proxy buffer. This leaves the default values (with no ingress configmap setting) unchanged:
If 'proxy-buffer-size' is set then, with this patch, both the buffer size and the memory allocation size is increased:
I have been using this patch from some time with both 0.8.3 and 0.9.0-beta.2.