Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable listen only on ipv6 and fix proxy_protocol #356

Merged
merged 1 commit into from
Mar 3, 2017

Conversation

gianrubio
Copy link
Contributor

@gianrubio gianrubio commented Mar 1, 2017

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 1, 2017
@gianrubio gianrubio closed this Mar 1, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 45.733% when pulling fda354858036379baf64f713485f2deee3f51949 on gianrubio:patch-1 into fb8e2d7 on kubernetes:master.

@gianrubio gianrubio changed the title disable listen only on ipv6 Disable listen only on ipv6 and fix proxy_protocol Mar 1, 2017
@gianrubio gianrubio reopened this Mar 1, 2017
@aledbf
Copy link
Member

aledbf commented Mar 1, 2017

@gianrubio this {{ if $cfg.UseProxyProtocol }} proxy_protocol {{ end }} {{ if eq $index 0 }} ipv6only=off{{end}} must be inside the else (443) because if there is passthroughBackends we cannot use proxy_protocol (it was already decoded)

@gianrubio
Copy link
Contributor Author

@aledbf I did the first change, the second (ipv6only=off) is required for both ports.

@gianrubio gianrubio closed this Mar 1, 2017
@gianrubio gianrubio reopened this Mar 1, 2017
- Always listen on ipv4 address for port 443
- Rollback previous PR kubernetes#227 that broke the proxy_protocol when passthroughBackends is disabled
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 45.733% when pulling 90fdea7 on gianrubio:patch-1 into fb8e2d7 on kubernetes:master.

@k8s-reviewable
Copy link

This change is Reviewable

@aledbf aledbf self-assigned this Mar 3, 2017
@aledbf
Copy link
Member

aledbf commented Mar 3, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2017
@aledbf aledbf merged commit 75124bc into kubernetes:master Mar 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants