Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort stream service ports to avoid extra reloads #311

Closed
wants to merge 1 commit into from

Conversation

ajwdev
Copy link

@ajwdev ajwdev commented Feb 20, 2017

This fixes a bug where an Ingress controller would continuously reload its configuration if multiple TCP/UDP stream services were specified. This is caused by the list of ports not being sorted.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 20, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 46.145% when pulling bc96000 on williamsandrew:sort-upstream-ports into 5ab0f28 on kubernetes:master.

@aledbf
Copy link
Member

aledbf commented Feb 21, 2017

@williamsandrew please sign the CLA

@ajwdev
Copy link
Author

ajwdev commented Feb 24, 2017

Sorry for the delay. CLA should be good now

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 24, 2017
@aledbf
Copy link
Member

aledbf commented Feb 24, 2017

@williamsandrew closing. The stream section is different now.

@aledbf aledbf closed this Feb 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants