Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update makefile gcloud docker command #293

Merged
merged 3 commits into from
Feb 17, 2017
Merged

Update makefile gcloud docker command #293

merged 3 commits into from
Feb 17, 2017

Conversation

tonglil
Copy link
Contributor

@tonglil tonglil commented Feb 17, 2017

Add -- between gcloud and docker args:

WARNING: The '--' argument must be specified between gcloud specific args on the left and DOCKER_ARGS on the right. IMPORTANT: previously, commands allowed the omission of the --, and unparsed arguments were treated as implementation args. This usage is being deprecated and will be removed in March 2017.
This will be strictly enforced in March 2017. Use 'gcloud beta docker' to see new behavior.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 17, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 45.893% when pulling bba7213 on tonglil:gcloud-docker into 698c084 on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 45.912% when pulling bba7213 on tonglil:gcloud-docker into 698c084 on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 45.893% when pulling bba7213 on tonglil:gcloud-docker into 698c084 on kubernetes:master.

@bprashanth
Copy link
Contributor

LGTM, thanks

@bprashanth bprashanth added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2017
@bprashanth bprashanth merged commit 3d9f89b into kubernetes:master Feb 17, 2017
@tonglil tonglil deleted the gcloud-docker branch March 7, 2017 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tonglil @k8s-reviewable @coveralls @bprashanth @k8s-ci-robot