Fix rewrite annotation parser #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
bprashanth
reviewed
Feb 13, 2017
| return nil, err | ||
| } | ||
|
|
||
| rt, _ := parser.GetStringAnnotation(rewriteTo, ing) |
There was a problem hiding this comment.
why are we eating this error instead of logging it?
There was a problem hiding this comment.
@bprashanth after this PR I will refactor the parser to not consider error when the annotation is missing (that is why I'm eating the error)
There was a problem hiding this comment.
Yeah recommend returning errAnnotationNotFound or something and ignoring the error just based on the type, eg:
type errAnnotationMissing struct {
errMsg string
}
func (e *errAnnotationMissing) Error() string { return e.errMsg}
rt, err := parser.GetStringAnnotation(rewriteTo, ing)
switch t := err.(type) {
case *errAnnotationMissing:
break
default:
glog.Errorf("Failed to parse annotation, %v", err)
}
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to return a Redirect type and not an error in order to get information about the SSL redirect defined in the backend
fixes #264
fixes #160