Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for disabling access_log globally #255

Merged
merged 1 commit into from
Feb 9, 2017
Merged

Adds support for disabling access_log globally #255

merged 1 commit into from
Feb 9, 2017

Conversation

rikatz
Copy link
Contributor

@rikatz rikatz commented Feb 9, 2017

This PR adds support for disabling the access_log globally, through a directive in ConfigMap.

It's related to issue #234

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 9, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 44.686% when pulling d0c4e0d on rikatz:nginx-disable-access-log into 2119b23 on kubernetes:master.

@aledbf aledbf self-assigned this Feb 9, 2017
@aledbf
Copy link
Member

aledbf commented Feb 9, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2017
@aledbf
Copy link
Member

aledbf commented Feb 9, 2017

@rikatz thanks!

@aledbf aledbf merged commit 9f83100 into kubernetes:master Feb 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aledbf aledbf

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rikatz @k8s-reviewable @coveralls @aledbf @k8s-ci-robot