Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify code to obtain TCP or UDP services #212

Merged
merged 1 commit into from
Feb 4, 2017
Merged

Simplify code to obtain TCP or UDP services #212

merged 1 commit into from
Feb 4, 2017

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Feb 2, 2017

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 2, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 44.409% when pulling 4343aab on aledbf:udp-services into e523ca9 on kubernetes:master.

@aledbf aledbf changed the title WIP: Simplify code to obtain TCP or UDP services Simplify code to obtain TCP or UDP services Feb 3, 2017
justinsb
justinsb approved these changes Feb 4, 2017
View reviewed changes
Copy link
Member

@justinsb justinsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aledbf
Copy link
Member Author

aledbf commented Feb 4, 2017

@justinsb thanks!

@aledbf aledbf merged commit 2b4a044 into kubernetes:master Feb 4, 2017
@aledbf aledbf deleted the udp-services branch February 5, 2017 22:35
@aledbf
Copy link
Member Author

aledbf commented Mar 14, 2017

@gianrubio ^^

@chancez
Copy link
Member

chancez commented Mar 14, 2017

I lied, this commit might not be it. Ill look into it more and file a bug report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinsb justinsb justinsb approved these changes

Assignees

@justinsb justinsb

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aledbf @k8s-reviewable @coveralls @chancez @justinsb @k8s-ci-robot