Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue for ratelimit #156

Merged
merged 1 commit into from
Jan 23, 2017
Merged

Fix issue for ratelimit #156

merged 1 commit into from
Jan 23, 2017

Conversation

tangle329
Copy link
Contributor

RPS should use limit_req_zone not limit_conn_zone.
Signed-off-by: Tang Le [email protected]

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 23, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 42.99% when pulling 50297c8 on tangle329:master into 8f9b710 on kubernetes:master.

@aledbf aledbf self-assigned this Jan 23, 2017
@aledbf
Copy link
Member

aledbf commented Jan 23, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2017
@aledbf
Copy link
Member

aledbf commented Jan 23, 2017

@tangle329 thanks!

@aledbf aledbf merged commit 527159e into kubernetes:master Jan 23, 2017
@bashofmann bashofmann mentioned this pull request Aug 16, 2018
Closed
@iameli iameli mentioned this pull request Feb 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aledbf aledbf

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tangle329 @k8s-reviewable @coveralls @aledbf @k8s-ci-robot