Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass redirect field in login page to get a proper redirect #1478

Merged
merged 1 commit into from
Oct 5, 2017
Merged

Pass redirect field in login page to get a proper redirect #1478

merged 1 commit into from
Oct 5, 2017

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Oct 5, 2017 •
edited
Loading

fixes #1314

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 5, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 5, 2017
@aledbf
Copy link
Member Author

aledbf commented Oct 5, 2017

@krogon-dp ping. Please use the image quay.io/aledbf/nginx-ingress-controller:0.254
The controller uses the redirect header but that is not enough when we need to login. The sign_in page was replaced by start. After this the workflow work as expected

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 23af068 on aledbf:rd into ** on kubernetes:master**.

@aledbf aledbf merged commit 51248f8 into kubernetes:master Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sign_in should be start
4 participants
@aledbf @k8s-reviewable @coveralls @k8s-ci-robot