Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit test cases for core.pkg.k8s #144

Merged
merged 1 commit into from
Jan 19, 2017

Conversation

chentao1596
Copy link

Add unit test cases for core.pkg.k8s.GetNodeIP &core.pkg.k8s.GetPodDetails,
and change the wrong word 'retuned' to the correct value 'returned' in the previous test cases, thank you!

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 19, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage increased (+0.7%) to 43.088% when pulling 5b31373 on chentao1596:add-unit-test-for-k8s into f1520a1 on kubernetes:master.

@aledbf
Copy link
Member

aledbf commented Jan 19, 2017

@chentao1596 thanks!

@aledbf aledbf self-assigned this Jan 19, 2017
@aledbf
Copy link
Member

aledbf commented Jan 19, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 19, 2017
@aledbf aledbf merged commit 27adc78 into kubernetes:master Jan 19, 2017
@chentao1596 chentao1596 deleted the add-unit-test-for-k8s branch January 20, 2017 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants