Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exec of readSecrets #1434

Merged
merged 2 commits into from
Sep 28, 2017
Merged

Fix exec of readSecrets #1434

merged 2 commits into from
Sep 28, 2017

Conversation

jcmoraisjr
Copy link
Contributor

Fixes the cast of syncIngress(interface{}) param. Without this PR new secrets aren't added to the local store.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 27, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 27, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 43.726% when pulling 62e000e on jcmoraisjr:jm-fix-read-secrets into 75cccbb on kubernetes:master.

@aledbf
Copy link
Member

aledbf commented Sep 28, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 28, 2017
@aledbf
Copy link
Member

aledbf commented Sep 28, 2017

@jcmoraisjr thanks!

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 43.696% when pulling 389c705 on jcmoraisjr:jm-fix-read-secrets into 75cccbb on kubernetes:master.

@aledbf aledbf merged commit 7d4cd1b into kubernetes:master Sep 28, 2017
@jcmoraisjr jcmoraisjr deleted the jm-fix-read-secrets branch September 28, 2017 01:00
@rowleyaj rowleyaj mentioned this pull request Sep 28, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aledbf aledbf

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jcmoraisjr @k8s-reviewable @coveralls @aledbf @k8s-ci-robot