Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding the tag and registry #1424

Merged
merged 1 commit into from
Sep 26, 2017
Merged

Conversation

albertvaka
Copy link
Contributor

The same way it is possible in controllers/nginx/Makefile

The same way it is possible in controllers/nginx/Makefile
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 26, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 26, 2017
@aledbf aledbf self-assigned this Sep 26, 2017
@aledbf
Copy link
Member

aledbf commented Sep 26, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 26, 2017
@aledbf
Copy link
Member

aledbf commented Sep 26, 2017

@albertvaka thanks!

@aledbf aledbf merged commit 6e24dc6 into kubernetes:master Sep 26, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 43.769% when pulling ea7771e on albertvaka:patch-1 into 7a7d3af on kubernetes:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants