Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error when cert or key is nil #1402

Merged
merged 1 commit into from
Sep 24, 2017
Merged

Conversation

auhlig
Copy link
Contributor

@auhlig auhlig commented Sep 21, 2017

If the key ("tls.crt"|"tls.key") in secret.Data map exists, but the value is nil the ingress controller crashes. Check this and return an error if this is the case to prevent:

...
backend_ssl.go:64] adding secret <ns>/<sn> to the local store
runtime.go:66] Observed a panic: "invalid memory address or nil pointer dereference" (runtime error: invalid memory address or nil pointer dereference)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 21, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 21, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 43.686% when pulling 003667f on auhlig:nilpointerfix into 37bd14d on kubernetes:master.

@aledbf
Copy link
Member

aledbf commented Sep 24, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2017
@aledbf
Copy link
Member

aledbf commented Sep 24, 2017

@auhlig thanks!

@aledbf aledbf merged commit 5a24f4d into kubernetes:master Sep 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants