Fix equals comparsion returing False if both objects have nil Targets or Services. #1365
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to reproduce
Why this happens
The Kubernetes service has
nil
in the address Target, unlike regular services. There's a bug inEndpoint.Equals()
that returnsfalse
incorrectly if both endpoints havenil
. This PR fixes it.While looking at the other
Equals
functions, I noticed the same bug withService
s in two places. I fixed them too, but I haven't checked if there is also a situation that can also cause endless reloads..